Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass at adding a language mode for elixir #1571

Merged
merged 8 commits into from
Oct 18, 2024

Conversation

jaresty
Copy link
Contributor

@jaresty jaresty commented Oct 11, 2024

I am not an elixir expert but I think this covers the basics. I wasn't able to find an elixir example in community forks so I put this together on my own.

When this gets merged I will be on the lookout for feedback to improve it incrementally in subsequent changes.

@jaresty
Copy link
Contributor Author

jaresty commented Oct 11, 2024

Addresses #1512

@jaresty
Copy link
Contributor Author

jaresty commented Oct 14, 2024

Related: cursorless-dev/cursorless#1844

Copy link
Collaborator

@phillco phillco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The majority looks good to me, just need to reduce some of the bespoke spoken forms that can actually be implemented via tags

lang/elixir/elixir.talon Outdated Show resolved Hide resolved
lang/elixir/elixir.talon Show resolved Hide resolved
lang/elixir/elixir.talon Outdated Show resolved Hide resolved
lang/elixir/elixir.talon Outdated Show resolved Hide resolved
lang/elixir/elixir.talon Outdated Show resolved Hide resolved
@jaresty jaresty requested a review from phillco October 18, 2024 21:39
@phillco phillco merged commit 899770b into talonhub:main Oct 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants